Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Turn on PortfolioView #28661

Merged
merged 5 commits into from
Nov 27, 2024
Merged

feat: Turn on PortfolioView #28661

merged 5 commits into from
Nov 27, 2024
+30 −7

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 22, 2024 •
edited by github-actions bot
Loading

Description

Sets PORTFOLIO_VIEW feature flag to true. Rather than fully removing this, we are defaulting to true in case we need to roll the feature back behind the feature flag.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review November 22, 2024 21:53
@gambinish gambinish requested review from a team as code owners November 22, 2024 21:53
@gambinish gambinish requested a review from darkwing November 22, 2024 21:54
@metamaskbot
Copy link
Collaborator

Builds ready [93fb977]
Page Load Metrics (2090 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18282579209019292
domContentLoaded18122509205018187
load18212581209019493
domInteractive24109442110
backgroundConnect1095422914
firstReactRender50279944722
getState4410087167
initialActions01000
loadScripts13631903156115072
setupStore64311105
uiStartup214130252467240115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.2 KiB (0.03%)
  • common: 221 Bytes (0.00%)

sleepytanya
sleepytanya previously approved these changes Nov 22, 2024
View reviewed changes
@gambinish gambinish added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a01df8c]
Page Load Metrics (2057 ± 134 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40526521968451217
domContentLoaded170025872028267128
load170826662057280134
domInteractive246634115
backgroundConnect997322613
firstReactRender165924115
getState49156992411
initialActions01000
loadScripts12971963154620799
setupStore6361073
uiStartup195530682335329158
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.2 KiB (0.03%)
  • common: 279 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b40ca8e]
Page Load Metrics (1932 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16952286195116881
domContentLoaded16802255190014871
load16942287193215474
domInteractive27136402311
backgroundConnect1084382613
firstReactRender16402263
getState5012994189
initialActions00000
loadScripts11791699141713163
setupStore6421074
uiStartup19332604221420096
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.2 KiB (0.03%)
  • common: 279 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit c0574f4 Nov 27, 2024
75 checks passed
@darkwing darkwing deleted the feat/portfolio-view-feature-flag-removal branch November 27, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sleepytanya sleepytanya sleepytanya approved these changes

@salimtb salimtb salimtb approved these changes

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gambinish @metamaskbot @salimtb @sleepytanya @darkwing